I’m the admin for an instance of OMP (3.3.0.5). It has been running for a couple of years now without much problem. But today I was asked to look into why the February summary of editorial activity email was sent to the main editor with the From address being the address of a regular user (who has Author and External Reviewer roles), rather than the default envelope sender.
This hasn’t happened before. There haven’t been any changes to the system that I know of.
Do you have any idea how this could have happened? In this case there wasn’t really a data breach, but we might not be so lucky next time.
Hmm… that seems odd. The only thing that immediately springs to mind is that that user might be designated as the primary contact in Journal Settings (but that seems unlikely…). What did the editorial activity summary look like or contain?
I’ve anonymized the name and links, but they were legit, as was the editorial-report.csv which was attached.
The principal and technical support contacts are what they should be. I’ll see if the recipient still has the email, and if they can get the header information, in case I can spot anything odd. I can see in the exim4 log on the server that the email was sent, but it doesn’t record the From address.
Just to say, I’ve seen the message headers now, and while the From address was wrong, the Reply-To one was correct.
In the config for the site, we have:
allow_envelope_sender = On
default_envelope_sender = email@example.com
force_default_envelope_sender = On
That said, the value for the default_envelope_sender isn’t the same as the principal contact, and it is the principal contact address which gets used as the From/Reply-To address.
I can’t rule out user error, but if you can point me in roughly the right direction I can look through the source code. I know PHP well, but OMP is quite a haystack.
I’m not an expert in these settings and/if you might need to modify the code (the general approach is to avoid this if you can help it), but I’m paging my colleague @jnugent here, who might be able to provide some advice.
So the force_default_envelope_sender setting will put the default_envelope_sender in the From: field. The other settings that are missing from this discussion are the DMARC ones:
force_dmarc_compliant_from can be set to On
and dmarc_compliant_from_displayname which contains a string to use as the replacement.
It’s the force_dmarc_compliant_from setting that does the heavy lifting here. It’s the setting that puts the envelope sender in the From field and then the actual person’s address in the Reply-To header.
If you’re using the force.... headers then nothing you put in the primary contact field will end up in an email. That’d be a code modification and all of that code lives in the Mail.inc.php class, and starts here: