Bug on get user query

Hi @asmecher
When a journal wants publish a new issue the system has an option with this title:
“sendIssueNotification” when the system user checked on, it send a “NOTIFICATION_TYPE_PUBLISHED_ISSUE” to all user with this line
$allUsers = $userGroupDao->getUsersByContextId($journalId);
and in getUsersByContextId function, call the getUsersById function.

But this is false i think you make a mistake in here, why ojs could send a message to disabled user! i mean fake user loaded with this query and it is not correct.

Please check it

Thank you very much

Hi @mbabaei,

What version of OJjS are you using? (Please include this with your posts.)

Regards,
Alec Smecher
Public Knowledge Project Team

Hi @asmecher

This is my ojs version :
ojs-3.1.2-1

Hi @mbabaei,

Thanks for reporting! This is filed at https://github.com/pkp/pkp-lib/issues/5385 and there’s a link there to a patch. (There are actually two – but they’re equivalent, and either one will work.)

Regards,
Alec Smecher
Public Knowledge Project Team

Hi @asmecher

Thank you very much.