Arabic strings missing

Translations
1

Hi everyone,
When I last checked the Arabic translation for “manager file of OJS”, I found it missing hundreds of pre-translated keys! That lead me to return to OJS project on Github to see what happened there.
Arabic translation there was present and intact, but there is a commit moving some language’s locale keys into pkp-lib.
Do I have to re-translate all missing keys again, or this is a routine development process and things would be solved soon in Weblate?

Thanks

2

Hi @vormia, this should be a routine development process and I think that things in Weblate should be resolved soon. But I’ll ping @asmecher who knows better how the integration with Weblate works.

Thanks for staying on top of the translations!

4

Hi @vormia,

I’ve just synced the Weblate translations against git main to see if that clears things up. Do you have an example of a locale key that appears to want translation in Weblate in the OJS “manager” component, but has been moved to pkp-lib?

Regards,
Alec Smecher
Public Knowledge Project Team

5

Hi @asmecher,

Thanks for looking into this.
In fact, I have 314 examples, here are a few of them:
http://translate.pkp.sfu.ca/translate/ojs/manager/ar_IQ/?checksum=32f8870173b2fa68
http://translate.pkp.sfu.ca/translate/ojs/manager/ar_IQ/?checksum=77e59699e1648260
http://translate.pkp.sfu.ca/translate/ojs/manager/ar_IQ/?checksum=455ec0f6c86f6112
http://translate.pkp.sfu.ca/translate/ojs/manager/ar_IQ/?checksum=e60042855a169a60
http://translate.pkp.sfu.ca/translate/ojs/manager/ar_IQ/?checksum=72f063b076556d54
http://translate.pkp.sfu.ca/translate/ojs/manager/ar_IQ/?checksum=83c842aa92ee04b
http://translate.pkp.sfu.ca/translate/ojs/manager/ar_IQ/?checksum=52eac41151c11a7b

All of the above keys and more, are reported as Need Translation in Weblate for the file Manager, but this file was 100% translated.

With regards,

6

Hi @vormia,

Ah, that helps – I’ve tracked this down to a syntax error in the .po file. See https://github.com/pkp/ojs/commit/dd8afd3db2d18ee8107aa10f73ccd6bbb5b7e3fc#r50830561 for details. It’s fixed for now but I’ve also filed a feature request adding validation to .po files during automated testing so these can be captured earlier and automatically. That’s here: Introduce PO file validation in validation testing · Issue #7063 · pkp/pkp-lib · GitHub

Weblate should pick up the missing content shortly.

Thanks,
Alec Smecher
Public Knowledge Project Team

7

Thanks @asmecher,
What you just did was very helpful.

1 Like
8

This topic was automatically closed after 6 days. New replies are no longer allowed.