A problem after upgrading the OJS 3.2.01

Hi asmecher,
Please see

Hi @Gokmen_ARSLAN,

I’ve filed this at PHP Fatal error in WebFeedPlugin · Issue #5680 · pkp/pkp-lib · GitHub. Can you try applying this change and report back whether it resolves the problem? pkp/pkp-lib#5680 Fix missing parameter in WebFeedGatewayPlugin · pkp/ojs@9978d8e · GitHub

Regards,
Alec Smecher
Public Knowledge Project Team

1 Like

No. it continues.
This is only in submission section. there is no problem other sections.

Hi @Gokmen_ARSLAN,

Can you check your PHP error log and post the result again?

Regards,
Alec Smecher
Public Knowledge Project Team

[27-Mar-2020 23:08:14 Europe/Istanbul] PHP Parse error: syntax error, unexpected ‘,’ in /home/journalp/public_html/plugins/generic/webFeed/WebFeedGatewayPlugin.inc.php on line 122
[27-Mar-2020 23:08:16 Europe/Istanbul] PHP Parse error: syntax error, unexpected ‘,’ in /home/journalp/public_html/plugins/generic/webFeed/WebFeedGatewayPlugin.inc.php on line 122
[27-Mar-2020 23:08:18 Europe/Istanbul] PHP Parse error: syntax error, unexpected ‘,’ in /home/journalp/public_html/plugins/generic/webFeed/WebFeedGatewayPlugin.inc.php on line 122
[27-Mar-2020 23:08:19 Europe/Istanbul] PHP Parse error: syntax error, unexpected ‘,’ in /home/journalp/public_html/plugins/generic/webFeed/WebFeedGatewayPlugin.inc.php on line 122
[27-Mar-2020 23:08:56 Europe/Istanbul] PHP Parse error: syntax error, unexpected ‘,’ in /home/journalp/public_html/plugins/generic/webFeed/WebFeedGatewayPlugin.inc.php on line 122
[27-Mar-2020 23:09:43 Europe/Istanbul] PHP Warning: assert(): assert(is_a($issue, ‘Issue’)) failed in /home/journalp/public_html/classes/issue/IssueAction.inc.php on line 29
[27-Mar-2020 23:09:43 Europe/Istanbul] PHP Fatal error: Uncaught Error: Call to a member function getJournalId() on null in /home/journalp/public_html/classes/issue/IssueAction.inc.php:31
Stack trace:
#0 /home/journalp/public_html/classes/search/ArticleSearch.inc.php(274): IssueAction->subscriptionRequired(NULL, Object(Journal))
#1 /home/journalp/public_html/plugins/generic/recommendByAuthor/RecommendByAuthorPlugin.inc.php(137): ArticleSearch->formatResults(Array)
#2 /home/journalp/public_html/lib/pkp/classes/plugins/HookRegistry.inc.php(107): RecommendByAuthorPlugin->callbackTemplateArticlePageFooter(‘Templates::Arti…’, Array)
#3 /home/journalp/public_html/lib/pkp/classes/template/PKPTemplateManager.inc.php(1237): HookRegistry::call(‘Templates::Arti…’, Array)
#4 /home/journalp/public_html/cache/t_compile/93b4f13326abf2c920de729fdcdace1580d9bcb7^addd65021fadf964339ab08cd1aa93ba59b14e9c_0.app.frontendobjectsarticledet.php(540): PKPTemplateManager->smartyCallHook(Array, Object(Smarty_Internal_Template))
#5 /home/journalp/public_html/lib/pkp/lib/vendor/smarty/sma in /home/journalp/public_html/classes/issue/IssueAction.inc.php on line 31
[27-Mar-2020 23:16:39 Europe/Istanbul] PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function APP\Services\SubmissionService::getInSections(), 1 passed in /home/journalp/public_html/plugins/generic/webFeed/WebFeedGatewayPlugin.inc.php on line 122 and exactly 2 expected in /home/journalp/public_html/classes/services/SubmissionService.inc.php:151
Stack trace:
#0 /home/journalp/public_html/plugins/generic/webFeed/WebFeedGatewayPlugin.inc.php(122): APP\Services\SubmissionService->getInSections(‘11’)
#1 /home/journalp/public_html/pages/gateway/GatewayHandler.inc.php(230): WebFeedGatewayPlugin->fetch(Array, Object(Request))
#2 /home/journalp/public_html/lib/pkp/classes/core/PKPRouter.inc.php(391): GatewayHandler->plugin(Array, Object(Request))
#3 /home/journalp/public_html/lib/pkp/classes/core/PKPPageRouter.inc.php(231): PKPRouter->_authorizeInitializeAndCallRequest(Array, Object(Request), Array, false)
#4 /home/journalp/public_html/lib/pkp/classes/core/Dispatcher.inc.php(143): PKPPageRouter->route(Object(Request))
#5 /home/journalp/public_html/lib/ in /home/journalp/public_html/classes/services/SubmissionService.inc.php on line 151

Hi @Gokmen_ARSLAN,

Are you sure you made the change correctly? It looks like there was a typo, and then the change was removed.

Regards,
Alec Smecher
Public Knowledge Project Team

Please see my change

} else {

		$submissionsInSections = Services::get('submission')->getInSections($issue->getId(), $journal->getId());
	}

and
#0 /home/journalp/public_html/plugins/generic/webFeed/WebFeedGatewayPlugin.inc.php(122): APP\Services\SubmissionService->getInSections(‘11’)
#1 /home/journalp/public_html/pages/gateway/GatewayHandler.inc.php(230): WebFeedGatewayPlugin->fetch(Array, Object(Request))
#2 /home/journalp/public_html/lib/pkp/classes/core/PKPRouter.inc.php(391): GatewayHandler->plugin(Array, Object(Request))
#3 /home/journalp/public_html/lib/pkp/classes/core/PKPPageRouter.inc.php(231): PKPRouter->_authorizeInitializeAndCallRequest(Array, Object(Request), Array, false)
#4 /home/journalp/public_html/lib/pkp/classes/core/Dispatcher.inc.php(143): PKPPageRouter->route(Object(Request))
#5 /home/journalp/public_html/lib/ in /home/journalp/public_html/classes/services/SubmissionService.inc.php on line 151
[27-Mar-2020 23:24:58 Europe/Istanbul] PHP Parse error: syntax error, unexpected ‘->’ (T_OBJECT_OPERATOR), expecting ‘,’ or ‘)’ in /home/journalp/public_html/plugins/generic/webFeed/WebFeedGatewayPlugin.inc.php on line 123
$versionDao = DAORegistry::getDAO(‘VersionDAO’); /* @var $versionDao VersionDAO */
$version = $versionDao->getCurrentVersion();

Also the submission section cannot via explorer. There is no problem in others.

Hi @Gokmen_ARSLAN,

What do you see at line 123 of plugins/generic/webFeed/WebFeedGatewayPlugin.inc.php? (Please also quote the surrounding lines.)

Regards,
Alec Smecher
Public Knowledge Project Team

Our last revision, see

image

Hi @Gokmen_ARSLAN,

That looks fine to me, though I see evidence in your log files of a series of different typos in the code. I’m going to assume the code is correctly changed and the log entries are outdated. Can you describe in detail what’s working and what’s not?

Regards,
Alec Smecher
Public Knowledge Project Team

I upgraded today. I tested many options. Currently, everything is okay. But there is a big space in submission section. Please the image above. Also the publons plugin is not working.

Hi @Gokmen_ARSLAN,

We don’t maintain the Publons plugin, but at a glance, it doesn’t look like it’s ready to work with OJS 3.2. I’d suggest removing it and checking if that fixes the submission problem. I’d also recommend flushing your browser cache and doing a hard-reload of the page, then checking the web browser’s error console to see if it shows any errors. Finally, after loading the submission page again, double-check to see whether anything new has appeared in your PHP error log.

Regards,
Alec Smecher
Public Knowledge Project Team

I did. Tere is no any error but no change.

Hi @Gokmen_ARSLAN,

I’m afraid I can’t diagnose this just based on as screenshot… I’d suggest exploring your browser developer tools to see whether there’s a request being denied in building the page or something similar.

Regards,
Alec Smecher
Public Knowledge Project Team

Hi!
This extra space exist in all OPS/OJS/OMP3.2+ fresh installation and hence its not upgrade or plugin specific issue. This empty space automatically disappear when you have submission list (space by list greater than the screen itself). In the case submission list is not enough the page can be scrolled down and this empty space exist. I am sharing 2 screenshot which may explain in a better way- (Extra space appears after scrolling down if the screen is empty due to less submission list)Screenshot%20(3) Screenshot%20(4)

Thank you asmecher and aabahishti

My screen is like your second screenshot. I have 11 tasks and there is more extra space. Is there any resolution to it?

Thanks again
Gökmen

Hi all,

I’m not sure, but this seems like two different problems; @aabahishti, you’re describing extra space at the bottom of the page (Fix extra space bellow submission list when it is empty by israelcefrin · Pull Request #83 · pkp/ui-library · GitHub should resolve this), but @Gokmen_ARSLAN, it seems like your page actually isn’t working, it’s not just a problem of extra space. Is that correct?

Regards,
Alec Smecher
Public Knowledge Project Team

asmecher

I didn’t find the resolution via the link(Fix extra space bellow submission list when it is empty by israelcefrin · Pull Request #83 · pkp/ui-library · GitHub. Could you send me directly?

Thank you

Hi @Gokmen_ARSLAN,

To apply that change, you’ll need to apply a patch in lib/ui-library, then rebuild the Javascript/vue.js dependencies. If you’re not sure how to do that, it’s best to wait until there’s a build that includes the fix. However, I’m not sure that’ll solve your problem – that’s purely a layout change/fix, and I think what you’re describing is something being actually broken.

Regards,
Alec Smecher
Public Knowledge Project Team