404 notification link

Hi,

in a NOTIFICATION_TYPE_REVIEWER_FORM_COMMENT notification, we got a 404 link (OJS 2.4.8):

https://[domain]/index.php/[name]/reviewer/submissionReview/1#peerReview

The correct link would be:

https://[domain]/index.php/[name]/editor/submissionReview/1#peerReview

that is, “editor” instead of “reviewer”.

In my own test installation (2.4.8-1), I could not replicate that error and in NotificationManager.inc.php line 70, everything seems to be okay:

case NOTIFICATION_TYPE_REVIEWER_FORM_COMMENT:
$role = $this->_getCachedRole($notification, array(ROLE_ID_EDITOR, ROLE_ID_SECTION_EDITOR, ROLE_ID_AUTHOR));
return $dispatcher->url($request, ROUTE_PAGE, null, $role, ‘submissionReview’, $notification->getAssocId(), null, ‘peerReview’);

Do you have any idea, how this link could have been created? The text of the notification is “A review form review has been submitted for …”.

best,
Carola

Hi @carola,

That does look like a bug – I’ve filed it at Incorrect notification URL · Issue #1819 · pkp/pkp-lib · GitHub.

Regards,
Alec Smecher
Public Knowledge Project Team