Missing admin.mergeUsers.noneEnrolled

Hello all,

I think this key is missing translation all over…
I grepped my folders, but nothing came up…

I used grep -R and grep -Ri “admin.mergeUsers.noneEnrolled” on ojs root, lib, locale and plugins… Nothing came up… only on the template file /templates/admin/selectMergeUser.tpl

Hello all,

I think I found the culprit:

The translation key that’s used in the journal management is ‘admin.mergerUsers.noneEnrolled’ (notice the merger, instead merge…) and all translation files.

On the admin page, though, the key is admin.mergeUsers.noneEnrolled…

Hi @ramon,

Thanks, I’ve corrected the typo:

Regards,
Alec Smecher
Public Knowledge Project Team

Thank you @asmecher for such quick response.
How do we mere mortals, who use the php tools/upgrade.php option, upgrade our systems?

Hi @ramon,

You can grab the commit as a patch. From the github issue, find the commit link for the appropriate branch for what you’re using (e.g. ojs-stable-2_4_8), add .diff to the end of the URL, and github will spit out a patch file. (Why they don’t seem to have a link to this in the github web interface is beyond me.)

Regards,
Alec Smecher
Public Knowledge Project Team

Hi @asmecher,

Do I have to be logged in to view as a diff?
I tried adding the .diff to the end of the URL and it threw an error page.
https://github.com/pkp/pkp-lib/tree/ojs-stable-2_4_8.diff

Hi @ramon,

You need to click on one of the commits first, according to what branch you’re working with.

Regards,
Alec Smecher
Public Knowledge Project Team

Hello @asmecher,

Ok… now I got it…
Kinda dull. Should really have the link to generate the diff.