External feed plugin on site level ins OJS 3.0.2

carola · May 23, 2017, 9:58am

Hi,

if I enable the external feed plugin on site level, in OJS 3.0.2, the browser returns a blank page when accessing the site frontend.

error log: [Tue May 23 11:26:45.514527 2017] [:error] [pid 5230] [client 160.45.169.136:51553] PHP Fatal error: Call to a member function getId() on null in /data/ojs/ojs-3/plugins/generic/externalFeed/ExternalFeedPlugin.inc.php on line 149

($currentJournal->getId())

Might be the same for the Web Feed Plugin.

best,
Carola

ctgraham · May 23, 2017, 1:13pm

This problem with the WebFeedPlugin was reported and fixed here:
https://github.com/pkp/ojs/pull/1373

Per the error message you report, the call for $journal->getId() on 149 should just be $journalId:

github.com

pkp/ojs/blob/ojs-stable-3_0_2/plugins/generic/externalFeed/ExternalFeedPlugin.inc.php#L149



		if ($this->getEnabled()) {
			// Only page requests will be handled
			if (!is_a($request->getRouter(), 'PKPPageRouter')) return false;
			$requestedPage = $request->getRequestedPage();

			if (empty($requestedPage) || $requestedPage == 'index') {
				$externalFeedDao = DAORegistry::getDAO('ExternalFeedDAO');
				$this->import('simplepie.SimplePie');

				$feeds =& $externalFeedDao->getExternalFeedsByJournalId($journal->getId());
				$output = '<div id="externalFeedsHome">';

				while ($currentFeed = $feeds->next()) {
					if (!$currentFeed->getDisplayHomepage()) continue;
					$feed = new SimplePie();
					$feed->set_feed_url($currentFeed->getUrl());
					$feed->enable_order_by_date(false);
					$feed->set_cache_location(CacheManager::getFileCachePath());
					$feed->init();

But additional work would be needed for the manage page:

github.com

pkp/ojs/blob/ojs-stable-3_0_2/plugins/generic/externalFeed/ExternalFeedPlugin.inc.php#L238-L239


		$journal = $request->getJournal();
		$journalId = $journal->getId();